| 1 | //===--- CloexecCreatCheck.cpp - clang-tidy--------------------------------===// |
|---|
| 2 | // |
|---|
| 3 | // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. |
|---|
| 4 | // See https://llvm.org/LICENSE.txt for license information. |
|---|
| 5 | // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception |
|---|
| 6 | // |
|---|
| 7 | //===----------------------------------------------------------------------===// |
|---|
| 8 | |
|---|
| 9 | #include "CloexecCreatCheck.h" |
|---|
| 10 | #include "clang/ASTMatchers/ASTMatchFinder.h" |
|---|
| 11 | |
|---|
| 12 | using namespace clang::ast_matchers; |
|---|
| 13 | |
|---|
| 14 | namespace clang::tidy::android { |
|---|
| 15 | |
|---|
| 16 | void CloexecCreatCheck::registerMatchers(MatchFinder *Finder) { |
|---|
| 17 | auto CharPointerType = hasType(InnerMatcher: pointerType(pointee(isAnyCharacter()))); |
|---|
| 18 | auto MODETType = hasType(InnerMatcher: namedDecl(hasName(Name: "mode_t" ))); |
|---|
| 19 | registerMatchersImpl(Finder, Function: functionDecl(isExternC(), returns(InnerMatcher: isInteger()), |
|---|
| 20 | hasName(Name: "creat" ), |
|---|
| 21 | hasParameter(N: 0, InnerMatcher: CharPointerType), |
|---|
| 22 | hasParameter(N: 1, InnerMatcher: MODETType))); |
|---|
| 23 | } |
|---|
| 24 | |
|---|
| 25 | void CloexecCreatCheck::check(const MatchFinder::MatchResult &Result) { |
|---|
| 26 | const std::string &ReplacementText = |
|---|
| 27 | (Twine("open (" ) + getSpellingArg(Result, N: 0) + |
|---|
| 28 | ", O_WRONLY | O_CREAT | O_TRUNC | O_CLOEXEC, " + |
|---|
| 29 | getSpellingArg(Result, N: 1) + ")" ) |
|---|
| 30 | .str(); |
|---|
| 31 | replaceFunc(Result, |
|---|
| 32 | WarningMsg: "prefer open() to creat() because open() allows O_CLOEXEC" , |
|---|
| 33 | FixMsg: ReplacementText); |
|---|
| 34 | } |
|---|
| 35 | |
|---|
| 36 | } // namespace clang::tidy::android |
|---|
| 37 | |
|---|
