| 1 | //===--- ThrowKeywordMissingCheck.cpp - clang-tidy-------------------------===// |
|---|
| 2 | // |
|---|
| 3 | // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. |
|---|
| 4 | // See https://llvm.org/LICENSE.txt for license information. |
|---|
| 5 | // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception |
|---|
| 6 | // |
|---|
| 7 | //===----------------------------------------------------------------------===// |
|---|
| 8 | |
|---|
| 9 | #include "ThrowKeywordMissingCheck.h" |
|---|
| 10 | #include "clang/AST/ASTContext.h" |
|---|
| 11 | #include "clang/ASTMatchers/ASTMatchFinder.h" |
|---|
| 12 | |
|---|
| 13 | using namespace clang::ast_matchers; |
|---|
| 14 | |
|---|
| 15 | namespace clang::tidy::bugprone { |
|---|
| 16 | |
|---|
| 17 | void ThrowKeywordMissingCheck::registerMatchers(MatchFinder *Finder) { |
|---|
| 18 | auto CtorInitializerList = |
|---|
| 19 | cxxConstructorDecl(hasAnyConstructorInitializer(InnerMatcher: anything())); |
|---|
| 20 | |
|---|
| 21 | Finder->addMatcher( |
|---|
| 22 | NodeMatch: cxxConstructExpr( |
|---|
| 23 | hasType(InnerMatcher: cxxRecordDecl( |
|---|
| 24 | isSameOrDerivedFrom(Base: matchesName(RegExp: "[Ee]xception|EXCEPTION" )))), |
|---|
| 25 | unless(anyOf( |
|---|
| 26 | hasAncestor( |
|---|
| 27 | stmt(anyOf(cxxThrowExpr(), callExpr(), returnStmt()))), |
|---|
| 28 | hasAncestor(decl(anyOf(varDecl(), fieldDecl()))), |
|---|
| 29 | hasAncestor(expr(cxxNewExpr(hasAnyPlacementArg(InnerMatcher: anything())))), |
|---|
| 30 | allOf(hasAncestor(CtorInitializerList), |
|---|
| 31 | unless(hasAncestor(cxxCatchStmt())))))) |
|---|
| 32 | .bind(ID: "temporary-exception-not-thrown" ), |
|---|
| 33 | Action: this); |
|---|
| 34 | } |
|---|
| 35 | |
|---|
| 36 | void ThrowKeywordMissingCheck::check(const MatchFinder::MatchResult &Result) { |
|---|
| 37 | const auto *TemporaryExpr = |
|---|
| 38 | Result.Nodes.getNodeAs<Expr>(ID: "temporary-exception-not-thrown" ); |
|---|
| 39 | |
|---|
| 40 | diag(TemporaryExpr->getBeginLoc(), "suspicious exception object created but " |
|---|
| 41 | "not thrown; did you mean 'throw %0'?" ) |
|---|
| 42 | << TemporaryExpr->getType().getBaseTypeIdentifier()->getName(); |
|---|
| 43 | } |
|---|
| 44 | |
|---|
| 45 | } // namespace clang::tidy::bugprone |
|---|
| 46 | |
|---|
