| 1 | //===--- UseBoolLiteralsCheck.cpp - clang-tidy-----------------------------===// |
|---|
| 2 | // |
|---|
| 3 | // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. |
|---|
| 4 | // See https://llvm.org/LICENSE.txt for license information. |
|---|
| 5 | // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception |
|---|
| 6 | // |
|---|
| 7 | //===----------------------------------------------------------------------===// |
|---|
| 8 | |
|---|
| 9 | #include "UseBoolLiteralsCheck.h" |
|---|
| 10 | #include "clang/AST/ASTContext.h" |
|---|
| 11 | #include "clang/ASTMatchers/ASTMatchFinder.h" |
|---|
| 12 | #include "clang/Lex/Lexer.h" |
|---|
| 13 | |
|---|
| 14 | using namespace clang::ast_matchers; |
|---|
| 15 | |
|---|
| 16 | namespace clang::tidy::modernize { |
|---|
| 17 | |
|---|
| 18 | UseBoolLiteralsCheck::UseBoolLiteralsCheck(StringRef Name, |
|---|
| 19 | ClangTidyContext *Context) |
|---|
| 20 | : ClangTidyCheck(Name, Context), |
|---|
| 21 | IgnoreMacros(Options.getLocalOrGlobal(LocalName: "IgnoreMacros" , Default: true)) {} |
|---|
| 22 | |
|---|
| 23 | void UseBoolLiteralsCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) { |
|---|
| 24 | Options.store(Options&: Opts, LocalName: "IgnoreMacros" , Value: IgnoreMacros); |
|---|
| 25 | } |
|---|
| 26 | |
|---|
| 27 | void UseBoolLiteralsCheck::registerMatchers(MatchFinder *Finder) { |
|---|
| 28 | Finder->addMatcher( |
|---|
| 29 | NodeMatch: traverse(TK: TK_AsIs, |
|---|
| 30 | InnerMatcher: implicitCastExpr( |
|---|
| 31 | has(ignoringParenImpCasts(InnerMatcher: integerLiteral().bind(ID: "literal" ))), |
|---|
| 32 | hasImplicitDestinationType(InnerMatcher: qualType(booleanType())), |
|---|
| 33 | unless(isInTemplateInstantiation()), |
|---|
| 34 | optionally(hasParent(explicitCastExpr().bind(ID: "cast" ))))), |
|---|
| 35 | Action: this); |
|---|
| 36 | |
|---|
| 37 | Finder->addMatcher( |
|---|
| 38 | NodeMatch: traverse(TK: TK_AsIs, |
|---|
| 39 | InnerMatcher: conditionalOperator( |
|---|
| 40 | hasParent(implicitCastExpr( |
|---|
| 41 | hasImplicitDestinationType(InnerMatcher: qualType(booleanType())), |
|---|
| 42 | unless(isInTemplateInstantiation()))), |
|---|
| 43 | eachOf(hasTrueExpression(InnerMatcher: ignoringParenImpCasts( |
|---|
| 44 | InnerMatcher: integerLiteral().bind(ID: "literal" ))), |
|---|
| 45 | hasFalseExpression(InnerMatcher: ignoringParenImpCasts( |
|---|
| 46 | InnerMatcher: integerLiteral().bind(ID: "literal" )))))), |
|---|
| 47 | Action: this); |
|---|
| 48 | } |
|---|
| 49 | |
|---|
| 50 | void UseBoolLiteralsCheck::check(const MatchFinder::MatchResult &Result) { |
|---|
| 51 | const auto *Literal = Result.Nodes.getNodeAs<IntegerLiteral>(ID: "literal" ); |
|---|
| 52 | const auto *Cast = Result.Nodes.getNodeAs<Expr>(ID: "cast" ); |
|---|
| 53 | bool LiteralBooleanValue = Literal->getValue().getBoolValue(); |
|---|
| 54 | |
|---|
| 55 | if (Literal->isInstantiationDependent()) |
|---|
| 56 | return; |
|---|
| 57 | |
|---|
| 58 | const Expr *Expression = Cast ? Cast : Literal; |
|---|
| 59 | |
|---|
| 60 | bool InMacro = Expression->getBeginLoc().isMacroID(); |
|---|
| 61 | |
|---|
| 62 | if (InMacro && IgnoreMacros) |
|---|
| 63 | return; |
|---|
| 64 | |
|---|
| 65 | auto Diag = |
|---|
| 66 | diag(Loc: Expression->getExprLoc(), |
|---|
| 67 | Description: "converting integer literal to bool, use bool literal instead" ); |
|---|
| 68 | |
|---|
| 69 | if (!InMacro) |
|---|
| 70 | Diag << FixItHint::CreateReplacement( |
|---|
| 71 | RemoveRange: Expression->getSourceRange(), Code: LiteralBooleanValue ? "true" : "false" ); |
|---|
| 72 | } |
|---|
| 73 | |
|---|
| 74 | } // namespace clang::tidy::modernize |
|---|
| 75 | |
|---|
