1// RUN: %check_clang_tidy %s cppcoreguidelines-pro-bounds-array-to-pointer-decay %t
2#include <stddef.h>
3
4namespace gsl {
5template <class T>
6class array_view {
7public:
8 template <class U, size_t N>
9 array_view(U (&arr)[N]);
10};
11}
12
13void pointerfun(int *p);
14void arrayfun(int p[]);
15void arrayviewfun(gsl::array_view<int> &p);
16size_t s();
17
18void f() {
19 int a[5];
20 pointerfun(p: a);
21 // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
22 pointerfun(p: (int *)a); // OK, explicit cast
23 arrayfun(p: a);
24 // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: do not implicitly decay an array into a pointer
25
26 pointerfun(p: a + s() - 10); // Convert to &a[g() - 10];
27 // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: do not implicitly decay an array into a pointer
28
29 gsl::array_view<int> av(a);
30 arrayviewfun(p&: av); // OK
31
32 int i = a[0]; // OK
33 int j = a[(1 + 2)];// OK
34 pointerfun(p: &a[0]); // OK
35
36 for (auto &e : a) // OK, iteration internally decays array to pointer
37 e = 1;
38}
39
40const char *g() {
41 return "clang"; // OK, decay string literal to pointer
42}
43const char *g2() {
44 return ("clang"); // OK, ParenExpr hides the literal-pointer decay
45}
46const char *g3() {
47 return __func__; // OK, don't diagnose PredefinedExpr
48}
49
50void f2(void *const *);
51void bug25362() {
52 void *a[2];
53 f2(static_cast<void *const*>(a)); // OK, explicit cast
54}
55
56void issue31155(int i) {
57 const char *a = i ? "foo" : "bar"; // OK, decay string literal to pointer
58 const char *b = i ? "foo" : "foobar"; // OK, decay string literal to pointer
59
60 char arr[1];
61 const char *c = i ? arr : "bar";
62 // CHECK-MESSAGES: :[[@LINE-1]]:23: warning: do not implicitly decay an array into a pointer
63 const char *d = i ? "foo" : arr;
64 // CHECK-MESSAGES: :[[@LINE-1]]:31: warning: do not implicitly decay an array into a pointer
65}
66

source code of clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/pro-bounds-array-to-pointer-decay.cpp